THE SPDX WIKI IS NO LONGER ACTIVE. ALL CONTENT HAS BEEN MOVED TO https://github.com/spdx

Difference between revisions of "Legal Team/Templatizing/ReviewXML"

From SPDX Wiki
Jump to: navigation, search
(Plan for review of XML license file)
(Plan for review of XML license file)
Line 16: Line 16:
 
Key things to look at during review:
 
Key things to look at during review:
 
# identify which parts of the license template are important or unimportant for purposes of matching (as per the Matching Guidelines)
 
# identify which parts of the license template are important or unimportant for purposes of matching (as per the Matching Guidelines)
# structural components - ensuring we have groups of clauses correctly identified (automated process takes care of most of this, but sanity check)
+
# structural components - ensuring we have groups of clauses correctly identified (automated process takes care of most of this, but sanity check). Note that if a license does not have info for certain tags (e.g., Notes or a Standard Header) these tags won't appear in the XML
 
# consider any changes that need to be made to the Matching Guidelines or License List Overview/description of fields
 
# consider any changes that need to be made to the Matching Guidelines or License List Overview/description of fields
  

Revision as of 19:56, 25 April 2016

Plan for review of XML license file

The files can be found here: https://github.com/spdx/license-list-XML

You will need to have a Github account to participate in the review. Let Jilayne know your Github account ID to be added to the repository team.

Key things to review before reviewing the XML files:

Watch the following videos that Kris made:

Key things to look at during review:

  1. identify which parts of the license template are important or unimportant for purposes of matching (as per the Matching Guidelines)
  2. structural components - ensuring we have groups of clauses correctly identified (automated process takes care of most of this, but sanity check). Note that if a license does not have info for certain tags (e.g., Notes or a Standard Header) these tags won't appear in the XML
  3. consider any changes that need to be made to the Matching Guidelines or License List Overview/description of fields

Process for Review

Labels created in Github: https://github.com/spdx/license-list-XML/labels

  • if you find a license that has acknowledgment text, then label it with "has acknowledgement" - for example see:
  • use ... define these??
  • If you have approved the content, but otherwise approved, use "approved" label
  • If the license is good to go, then click on the "merge pull request" and you're done!